Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup always stacks up a new nyxt:help page each time #2057

Open
Ambrevar opened this issue Jan 26, 2022 · 5 comments
Open

Startup always stacks up a new nyxt:help page each time #2057

Ambrevar opened this issue Jan 26, 2022 · 5 comments
Labels
3-series Related to releases whose major version is 3. bug history Related to history handling. lisp-protocol nyxt/lisp URLs and internal pages.

Comments

@Ambrevar
Copy link
Member

If you restore sessions and keep nyxt:help open, notice how the page keeps stacking up.

This was not a problem before Lisp URLs because internal buffers were not persisted in the session.

Now I suppose that we should update the startup procedure to not fire up a new nyxt:help page if one is already restored.

@aartaka What do you think?

@aartaka
Copy link
Contributor

aartaka commented Jan 26, 2022

Yes, that feels most intuitive!

@aartaka aartaka added 3-series Related to releases whose major version is 3. bug history Related to history handling. lisp-protocol nyxt/lisp URLs and internal pages. labels Jan 26, 2022
@Ambrevar
Copy link
Member Author

Actually it's a bit more subtle: help should not re-create a buffer if it finds another one with the same name in help-mode. And the problem is this: restored buffers don't restore their modes!!! :/

See #2064.

@Ambrevar Ambrevar mentioned this issue Nov 18, 2022
19 tasks
@aadcg
Copy link
Member

aadcg commented Mar 23, 2023

This one seems critical.

@Ambrevar
Copy link
Member Author

Ambrevar commented Mar 24, 2023

And also pretty easy to fix. @aartaka @aadcg @jmercouris Anyone motivated to work on it?

Forget it, forgot this depends on #2064. I'll work on it then :p

@aartaka
Copy link
Contributor

aartaka commented Mar 24, 2023

#2627 could fix both #2064 and #1695, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-series Related to releases whose major version is 3. bug history Related to history handling. lisp-protocol nyxt/lisp URLs and internal pages.
Development

No branches or pull requests

3 participants