Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double tooltips for sidebar menu #1101

Open
sahilkumar003 opened this issue May 13, 2024 · 3 comments
Open

Remove double tooltips for sidebar menu #1101

sahilkumar003 opened this issue May 13, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@sahilkumar003
Copy link

Describe the bug

Double tooltips is showing for sidebar menu

How to Reproduce

hover and hold sidebar menu for some seconds

  • Screenshots
    image

Expected behavior

Only one tooltip should be shown instead of two

@sahilkumar003 sahilkumar003 added the bug Something isn't working label May 13, 2024
aeworxet added a commit to aeworxet/asyncapi-studio that referenced this issue May 19, 2024
@aeworxet
Copy link
Contributor

Removed duplication of tooltips as part of work on #661.
(but this is only for the future; if you want to submit an immediate fix, go ahead)

In current Studio's setup tooltips are duplicated by simultaneously indicating:

  • title attribute of HTML tags button
  • React's component <Tooltip />

Cypress can test only programmatic tooltips, so I removed duplicating title attributes.
Please take this Cypress' peculiarity into account when working on the design system (@asyncapi/studio-ui.)

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 17, 2024
@aeworxet
Copy link
Contributor

aeworxet commented Oct 1, 2024

Is this still relevant with the new Studio?

@github-actions github-actions bot removed the stale label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants