-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re add protobuff parser #758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/rtm |
/rtm |
Would it make sense to merge this into |
It can go in the master as well. But this pr is not compatible with master. |
I see the |
Lets just do the change to And it already is there on master, so no need to change anything there. Its only relevant on |
@jonaslagoni protobuf-parser was not jet part in master. I only add it for next branch so far. Here the pr for master #759 |
Ahh, right @GreenRover 👍 |
Back to this issue. What needs to be done to get it merged? |
I really dont see it as necessary to add it to master as well, but of course if you use v0 somewhere it would be nice to have 😄 |
Me neither, i would prefer to get next released because it fixes many of my open issue with current release. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🎉 This PR is included in version 1.0.0-next.53 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Any one an idea why only react-component: |
@GreenRover I think it is cause all by outdated pipelines -> https://github.com/asyncapi/asyncapi-react/actions/runs/6111938173/job/16588288332 let's just release -> #761 |
re enable protobuff parser lib