Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set Access-Control-Allow-Origin header for playground devserver #742

Closed
wants to merge 1 commit into from
Closed

chore: Set Access-Control-Allow-Origin header for playground devserver #742

wants to merge 1 commit into from

Conversation

Laupetin
Copy link

Description

Changes proposed in this pull request:

  • Set "Access-Control-Allow-Origin" header for playground dev server to "*" to allow playground to fetch an external schema from somewhere other than same origin when running it locally.

image
(Trying to load schema from http://localhost:8090/docs/asyncapi.json with playground devserver running on http://localhost:3000 for example)

Related issue(s)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Laupetin
Copy link
Author

May have misunderstood what i was doing wrong, my bad

@Laupetin Laupetin closed this Jul 28, 2023
@Laupetin Laupetin deleted the dev-server-cors-header branch July 28, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant