Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show operation summary on sidebar #595

Merged
merged 5 commits into from
Jan 31, 2023

Conversation

sarisia
Copy link

@sarisia sarisia commented May 8, 2022

Description

Prior to @asyncapi/[email protected],
operations' summary is shown in sidebar but current version does not:

(code from v0.20.1)

https://github.com/asyncapi/html-template/blob/d2c4513eef9b33bfc977ed5ed92eb188e8988b62/partials/sidebar.html#L50-L58

Changes proposed in this pull request:

  • if operation has a summary, show it on sidebar

Current behavior

image

Updated behavior

image

Related issue(s)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarcloud
Copy link

sonarcloud bot commented May 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarisia Thanks for PR! Looks great, however, I suggest to display with summary also channel name to identify which channel is described, like {channelName} {optionalSummary}.

@sarisia
Copy link
Author

sarisia commented Jun 25, 2022

@magicmatatjahu Thank you for reviewing and sorry for my late response.

I think adding channel name to sidebar makes the line length too long and users may feel hard to find
operations at a grance.

At Redoc (OpenAPI docs generator) they only show summary
on sidebars for years , so I think it's enough to do so.

What do you think?

@magicmatatjahu
Copy link
Member

@sarisia I would also prefer to add the name of the channel. Here is what it looks like for example.

image

WDYT?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Oct 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member

@sarisia Thanks for contribution!

@magicmatatjahu magicmatatjahu merged commit fcb6d31 into asyncapi:next Jan 31, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.46 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sarisia
Copy link
Author

sarisia commented Jan 31, 2023

#595 (comment)
@sarisia I would also prefer to add the name of the channel. Here is what it looks like for example.

image

WDYT?

Sorry for not responding for a long time.

Maybe make it controllable by sidebar option is better, but since I'm not the React guy, it may take some time to make PR...

Maybe I'll create an new follow up issue later. Thanks!

@magicmatatjahu
Copy link
Member

@sarisia No problem! Yeah, it can be :) Please create issue and I will make PR. I would like to close as many issues as possible in the next few days/weeks, because later I will not have time to do it.

@sarisia
Copy link
Author

sarisia commented Feb 2, 2023

@magicmatatjahu #701, thanks!

@shanewazabbas
Copy link

I don't like this change. If a summary is really long, it makes the sidebar look like a mess...

@sarisia
Copy link
Author

sarisia commented Sep 8, 2023

If a summary is really long, it makes the sidebar look like a mess...

Indeed. We had same problem for very long channel name.

#701 suggests adding sidebar option to change the priority between channelName and summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants