Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish wheels for linux #18

Closed
DetachHead opened this issue Oct 17, 2024 · 9 comments
Closed

publish wheels for linux #18

DetachHead opened this issue Oct 17, 2024 · 9 comments

Comments

@DetachHead
Copy link

Is your feature request related to a problem? Please describe.
currently there are only wheels for windows and macos, so it fails to build when i attempt to run it in my CI which uses ubuntu

Describe the solution you'd like
publish wheels for linux

Describe alternatives you've considered
figuring out why it fails to build. i would rather not have to figure out how to install the rust compiler in my CI, as our dockerfile is already very bloated and debugging build issues in CI is extremely painful

Additional context
Add any other context or screenshots about the feature request here.

@KotlinIsland
Copy link

i figured it out!

curl https://sh.rustup.rs -sSf | sh

@DetachHead
Copy link
Author

doesnt work

@aswinnnn
Copy link
Owner

Hey, for the latest stable, i do have wheels published in the releases page. you'll find it with the manylinux suffix. Your CI should be able to do this:

pip install https://github.com/aswinnnn/pyscan/releases/download/v0.1.4/pyscan_rs-0.1.4-py3-none-manylinux_2_34_x86_64.whl

I just tested it on my Debian and it installs fine. Let me know if it doesn't work.

@KotlinIsland
Copy link

I use pypi in my ci, would it be possible to upload the wheels to the pypi release?

@aswinnnn
Copy link
Owner

There's no way to edit pypi releases to add wheels unfortunately, My PyPI CI fails horribly at manylinux builds, which is why I manually built it and uploaded it to releases instead.

However, I have been working on and off on a new version of pyscan (#17), I could upload a beta version with the manylinux wheels included. Would you be into that? There might be unforeseen bugs which you might have to report, if you're cool with it.

@KotlinIsland
Copy link

There's no way to edit pypi releases to add wheels unfortunately

I've done it many times

@aswinnnn
Copy link
Owner

I can't seem to find such an option, I'll look more into it.

@KotlinIsland
Copy link

so what i've done is run twine upload with the new wheels. it won't let you override an existing release file/wheel, but it will let you add new ones

@aswinnnn
Copy link
Owner

thank you! the wheel is included now. Let me know if you have any issues.

@aswinnnn aswinnnn closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants