Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build google benchmarks (development branch) #364

Open
krishnakumarg1984 opened this issue Jun 21, 2023 · 2 comments
Open

Unable to build google benchmarks (development branch) #364

krishnakumarg1984 opened this issue Jun 21, 2023 · 2 comments
Assignees

Comments

@krishnakumarg1984
Copy link
Collaborator

krishnakumarg1984 commented Jun 21, 2023

When trying to build the project (at development branch current HEAD) with benchmarks enabled as follows:

$ mkdir build && cd build
$ conan install .. --build missing -pr:h=default -pr:b=default -o benchmarks=on 
$ conan build ..

we get the following error:

sopt/cpp/benchmarks/wavelets.cc:2:10: fatal error: benchmark/benchmark.h: No such file or directory
    2 | #include <benchmark/benchmark.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [cpp/benchmarks/CMakeFiles/benchmark_wavelets.dir/build.make:76: cpp/benchmarks/CMakeFiles/benchmark_wavelets.dir/wavelets.cc.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1761: cpp/benchmarks/CMakeFiles/benchmark_wavelets.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
gmake: *** [Makefile:146: all] Error 2
ERROR: conanfile.py (sopt/4.0.0): Error in build() method, line 78
        cmake.build()
        ConanException: Error 2 while executing cmake --build "sopt/build" '--' '-j8'
@tkoskela
Copy link
Contributor

This is a bit confusing, since it is a requirement in

requires = ["eigen/3.3.7","catch2/2.13.7","benchmark/1.6.0", "libtiff/4.4.0",]

Is this just a matter of missing

find_package(benchmark)

in https://github.com/astro-informatics/sopt/blob/development/cmake_files/dependencies.cmake

@SJaffa
Copy link
Contributor

SJaffa commented Jun 28, 2023

This info might help: https://github.com/google/benchmark#usage-with-cmake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants