Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0 Int not renders #66

Open
mkikets99 opened this issue Feb 8, 2021 · 2 comments
Open

0 Int not renders #66

mkikets99 opened this issue Feb 8, 2021 · 2 comments

Comments

@mkikets99
Copy link

mkikets99 commented Feb 8, 2021 •
edited
Loading

I find out that if we have 0 in one of column results then that 0 is not renders
Screenshot from 2021-02-08 20-27-30
Screenshot from 2021-02-09 00-40-32

Is that ok? or needs a fix?
@mkikets99 mkikets99 mentioned this issue Feb 9, 2021
Open
@HavelEstrada
Copy link

HavelEstrada commented May 13, 2022 •
edited
Loading

@mkikets99 I noticed the same problem, 0 not rendered. Is there any fix for that?

@mkikets99
Copy link
Author

@mkikets99 I noticed the same problem, 0 not rendered. Is there any fix for that?

It fixed on my fork...
The issue was that it simply checks for data to be not false, but int 0 equals false boolean.
it also can be tricked by just transforming int into string...
But on my solution it better to be already checked for int 0 because some data with zeros might be important (as i know) on developing route

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkikets99 @HavelEstrada