Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Login Feature #58

Closed
wants to merge 7 commits into from
Closed

Add Login Feature #58

wants to merge 7 commits into from

Conversation

mandeep168
Copy link

@mandeep168 mandeep168 commented Dec 15, 2021 •
edited
Loading

Related Issuse or bug

  • Added a responsive login page with google and github automatic login support.

Fixes: #38

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I test it locally by running the website on localhost. One need to install firebase which can be install using "npm install firebase" other things are same as previous.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

image
image
Login using google
image
Login using github
image
If the fields are left blank.
image
Mobile View
mobile1

mobile2

@welcome
Copy link

welcome bot commented Dec 15, 2021

Hello there!👋 Welcome to the project!💖⚡

Thank you and congrats🎉 for opening your very first issue in this project. We at hackStation provide a platform to share your work in number. Please adhere to our Code of Conduct.🙌 Kindly ensure you have fulfilled all the project guidelines.

@aakankshabhende
Copy link
Collaborator

Good work @mandeep168
Can you please put your github page link here

@mandeep168
Copy link
Author

Sure.
https://github.com/mandeep168

@aakankshabhende
Copy link
Collaborator

Sure. https://github.com/mandeep168

I meant to put link of the changes you made on your local repository

@mandeep168
Copy link
Author

Sure. https://github.com/mandeep168

I meant to put link of the changes you made on your local repository

https://github.com/mandeep168/hackstation/tree/LoginPage

@aakankshabhende
Copy link
Collaborator

aakankshabhende commented Jan 1, 2022 •
edited
Loading

Are your changes responsive? @mandeep168
Also please resolve the conflicts to get PR merged into the main.

@mandeep168
Copy link
Author

mandeep168 commented Jan 2, 2022 •
edited
Loading

@aakankshabhende Yes changes are responsive and I have resolved the conflicts.

@mandeep168
Copy link
Author

@aakankshabhende I have added the screenshots at the end.

@aakankshabhende
Copy link
Collaborator

@mandeep168 please resolve the conflicts to get PR merged into the main.

@mandeep168 mandeep168 closed this Jan 25, 2022
@mandeep168 mandeep168 deleted the LoginPage branch January 25, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login page component
2 participants
@mandeep168 @aakankshabhende