Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger-JS version #77

Open
NachoSoto opened this issue Dec 6, 2017 · 5 comments
Open

Danger-JS version #77

NachoSoto opened this issue Dec 6, 2017 · 5 comments

Comments

@NachoSoto
Copy link

I couldn't find anything: is there a Danger-JS version of this plugin? If not I guess I'll switch to using the Ruby version, or is it possible to have 2 Dangerfiles?

@ashfurrow
Copy link
Owner

Good question! So this is something Orta and I have discussed before. There is no Danger-JS version of the plugin but what we're looking to do is move away from Ruby's Danger altogether. Danger-Swift (which is just Danger-JS under the hood over a JSON bridge) was recently modified to support plugins and I'm planning to build the first Danger-Swift plugin this weekend.

Not a totally satisfying answer I know, but I think moving Danger checks for SwiftLint into a Danger-Swift environment makes sense in the long run. Let me know what you think.

@NachoSoto
Copy link
Author

Interesting! Thanks for the answer. I'm using the Ruby version for the time being, and I'll plan to migrate to Danger-Swift soon :)

@ashfurrow
Copy link
Owner

Cool! I let you know on this issue when it's ready for use 👍

@ashfurrow
Copy link
Owner

Okay so for anyone following along or wondering why Github is giving 404's, I changed the name of this repo from danger-swiftlint to danger-ruby-swiftlint; then I created a new repo called danger-swiftlint to work on the Danger-Swift plugin for SwiftLint. Still very early stages – onwards and upwards!

@ashfurrow
Copy link
Owner

Alrighty, the plugin should be working now. Let me know if anyone runs into issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants