Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

danger-swxftlint 0.7.0 fails when specifying config file #49

Open
valeriomazzeo opened this issue Jul 19, 2017 · 6 comments
Open

danger-swxftlint 0.7.0 fails when specifying config file #49

valeriomazzeo opened this issue Jul 19, 2017 · 6 comments

Comments

@valeriomazzeo
Copy link

Very odd, tested 0.6.0 and it works fine.
Although, 0.7.0 works with this configuration:

swiftlint.lint_files

It does fail with this:

swiftlint.config_file = '.swiftlint.yml'
swiftlint.lint_files

The logs report fatal error but it doesn't make CI like travis fail the build and it neither report any type of error whatsoever on the pull request.

fatal error: Could not read configuration file at path '/Users/myuser/Projects/myProject/mySubProject/Sources/Auth0Provider/Authentication/Resources/SignIn.swift/.swiftlint.yml': file /Users/marcelofabri/Westfield/SwiftLint/Source/SwiftLintFramework/Models/Configuration.swift, line 167
/Users/myuser/Projects/myProject/mySubProject/Sources/Auth0Provider/Authentication/Resources/SignIn.swift/.swiftlint.yml:File not found.
fatal error: Could not read configuration file at path '/Users/myuser/Projects/myProject/mySubProject/Sources/AuthenticationProvider/Controllers/AuthenticationController.swift/.swiftlint.yml': file /Users/marcelofabri/Westfield/SwiftLint/Source/SwiftLintFramework/Models/Configuration.swift, line 167
/Users/myuser/Projects/myProject/mySubProject/Sources/AuthenticationProvider/Controllers/AuthenticationController.swift/.swiftlint.yml:File not found.

Errors are weird, not sure what's happening there.
Somehow it seems there is some hardcoded path coming from swiftlint directly.

I am using the latest swiftlint 0.20.1.

@marcelofabri
Copy link
Collaborator

This is a SwiftLint issue, sorry about that. Filled realm/SwiftLint#1694 to track it.

@marcelofabri
Copy link
Collaborator

marcelofabri commented Jul 19, 2017

And PR landed in realm/SwiftLint#1695. Could you please try it to see if it solves the issue?

@marcelofabri
Copy link
Collaborator

Also, a current workaround for this issue is to provide an absolute path for --config.

@valeriomazzeo
Copy link
Author

@marcelofabri I can try if you release an hot fix of swiftlint 0.20.2

@jpsim
Copy link

jpsim commented Jul 24, 2017

There are a number of ways to install SwiftLint without requiring an official release. Please see https://github.com/realm/SwiftLint#installation

Notably, brew install swiftlint --HEAD

@chooblarin
Copy link

It seems like SwiftLint 0.21.0 has the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants