Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Shnaton parser is insensitive to changes if a course is already in cache #114

Open
matanel-oren opened this issue Jul 9, 2020 · 1 comment
Labels
bug Something isn't working logic

Comments

@matanel-oren
Copy link
Contributor

There is no mechanism that checks if an html file of a course was changed after we toke and store it.
I didn't see where we re-download the files that already in cache. It is not necessarily in touch to the parser, probably should be done in a separate script.

@asaf-kali
Copy link
Owner

You a correct, that is a good point. The cache was originally made for quick development purposes, and not for production. This needs to be addresses.

@asaf-kali asaf-kali added bug Something isn't working logic labels Jul 9, 2020
@asaf-kali asaf-kali changed the title Bug: Shnaton parser is insensitive to changes if a course is already in cache BUG: Shnaton parser is insensitive to changes if a course is already in cache Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logic
Projects
None yet
Development

No branches or pull requests

2 participants