refactor(PHIRE-218): use MasonryFlashList of full screen grids #9332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
force-pushed
the
gkartalis/PHIRE-218
branch
2 times, most recently
from
fe77a00 to
28beee6
Compare
gkartalis
force-pushed
the
gkartalis/PHIRE-218
branch
from
3dc736e to
7d62286
Compare
gkartalis
requested review from
damassi,
olerichter00,
MounirDhahri and
brainbicycle
|
A thing that I noticed is that for the LotsByArtistsYouFollow screen we don't have any analytics for pageviews. I will ask in #analytics-help to see if we should add them |
| height={imgHeight} | ||
| navigateToPageableRoute={navigateToPageableRoute} | ||
| /> | ||
| </Flex> |
brainbicycle
approved these changes
Sep 27, 2023
Comment on lines
+47
to
+49
| <Flex | ||
| pl={columnIndex === 0 ? 0 : 1} | ||
| pr={NUM_COLUMNS_MASONRY - (columnIndex + 1) === 0 ? 0 : 1} |
There was a problem hiding this comment.
nitpick: it would be nice to do some explorations on supporting gaps to our Flex component to avoid conditional paddings.
There was a problem hiding this comment.
that's a great point, we can use also https://reactnative.dev/docs/0.71/flexbox#row-gap-column-gap-and-gap when we upgrade to either 0.71 or 0.72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-218
Description
Important
Nothing changed UI wise!
Replacing the following surfaces with the new MasonryFlashList.
Created also a reusable component for FullScreen Masonry grids (there is another one for the tabs).
Refactored surfaces:
Note
There was also a bonus refactor on the
LotsByArtistsYouFollow.tsxsurface that refactored the queryRenderer to use relay hooks instead ⭐️PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.