feat(onyx-356): single activity panel notification screen #9327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains the following changes:
|
MounirDhahri
previously approved these changes
Sep 27, 2023
| size={rowImageWidth} | ||
| artworkHref={artworkNodes[0].href!} | ||
| /> | ||
| <Spacer x={`${IMAGE_OFFSET}px`} /> |
There was a problem hiding this comment.
Q: any reason for not using x={1} here?
There was a problem hiding this comment.
My thinking was that I have a constant IMAGE_OFFSET (in pixels), and I do all math in this component based on this constant, for instance rowImageWidth is calculated like this: (width - (TOTAL_HORIZONTAL_PADDING + IMAGE_OFFSET)) / 2.
If I were to change IMAGE_OFFSET to 15 pixels, for instance, nothing would be broken
There was a problem hiding this comment.
but I'll try to rewrite with Flex gap instead, so never mind 😄
nickskalkin
dismissed stale reviews from MounirDhahri and dblandin
via
6d96179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-356
Description
I've added a new screen for individual activity panel notifications. You can navigate to it by clicking on an activity panel item from activity panel or latest activities rail.
Demo
demo.mp4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.