Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update doctor script #9307

Merged
merged 5 commits into from
Sep 22, 2023
Merged

fix: update doctor script #9307

merged 5 commits into from
Sep 22, 2023

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Sep 21, 2023

This PR resolves []

Description

Inspired by @MounirDhahri suggestion in platform practice.

Screenshot 2023-09-22 at 9 19 47 AM

Notes:

  • We are still on Xcode 14.3 officially but looking to get to 15 soon so that version number is a bit ahead
  • Android studio I am not sure we officially document which version is needed but maybe we should?

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Update doctor script with more checks, fix broken checks - brian

Need help with something? Have a look at our docs, or get in touch with us.

@brainbicycle brainbicycle self-assigned this Sep 21, 2023
@brainbicycle brainbicycle marked this pull request as draft September 21, 2023 20:21
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Sep 21, 2023

This PR contains the following changes:

  • Dev changes (Update doctor script with more checks, fix broken checks - brian)

Generated by 🚫 dangerJS against 25bbcbe

@brainbicycle brainbicycle marked this pull request as ready for review September 22, 2023 13:21
@brainbicycle brainbicycle removed their assignment Sep 22, 2023
@brainbicycle brainbicycle changed the title fix: update failing checks in doctor script fix: update doctor script Sep 22, 2023
Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so cool!

I don't think there is any limitation when it comes to android studio version but more with the android sdk apis https://reactnative.dev/docs/environment-setup.

Although more sdk versions work its not as strict as apple is

Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM. I think we should look as well into adding some stuff related to Android in the future, maybe jdk check for version 11 etc...

@gkartalis gkartalis merged commit 4d25a2e into main Sep 22, 2023
@gkartalis gkartalis deleted the brian/doctor-doctor branch September 22, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants