Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] git stash store -m 'msg' 'commit-id' broken format #91

Open
wenfangdu opened this issue Apr 12, 2023 · 6 comments · May be fixed by #92
Open

[Bug] git stash store -m 'msg' 'commit-id' broken format #91

wenfangdu opened this issue Apr 12, 2023 · 6 comments · May be fixed by #92

Comments

@wenfangdu
Copy link

Repro Steps:

ss is an alias for stash.
image
image
image
image

@artrz
Copy link
Owner

artrz commented Apr 24, 2023

Thanks for your report. I`ll check it out as soon as I get some free time.

@artrz
Copy link
Owner

artrz commented May 1, 2023

@wenfangdu I'm currently reviewing this and even tough I know why the error is occurring I'm not able to reproduce it. Basically the extension is parsing the values based on substrings and tokens which presumably are not part of your stashes' subject.

May I know your git version and the output of git stash list --format="%s" on the repo you're having issues with?
The extension is expecting lines starting with either WIP on branchname: or On branchname: . I guess that in the case of your screenshots branchname would be main.

@wenfangdu
Copy link
Author

@Arturock Thanks for the investigation.
image

@wenfangdu
Copy link
Author

@Arturock Can you reproduce it now? If not, I'll try my best to help you!

@artrz
Copy link
Owner

artrz commented Jun 8, 2023

@wenfangdu Unfortunately I haven't been able to look at this, so yeah, feel free to dig the code and create PR if you will.
I'd start by taking a look into StashGit.getStashes() (where data is gathered) and StashLabels.parseStashLabel() (which presents the info).
To see how the explorer is built check TreeDataProvider and TreeItemFactory

@wenfangdu wenfangdu linked a pull request Jul 6, 2023 that will close this issue
@wenfangdu
Copy link
Author

@Arturock Hi, where's the --format option documented? Couldn't find it here: https://git-scm.com/docs/git-stash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants