Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Improvements & Options with CodeGen + Dropping Ruby 1.9 #70

Open
OmriSama opened this issue Aug 9, 2021 · 3 comments
Open

Comments

@OmriSama
Copy link

OmriSama commented Aug 9, 2021

Hi. I'm not sure if the Twitch team still maintains this package, but I wanted to suggest (and potentially help) with a couple of changes to the Code Generator plugin.

  • There should be an options to generate only Services, or Clients (not both)
  • There should be options for Module/class naming
  • There should be options for the relative filenames that Twirp expects (from protoc --ruby_out)

Let me know if any of this is planned!

Thanks in advance

EDIT: I was also wondering if there are any plans to drop Ruby 1.9.

@OmriSama OmriSama changed the title Additional Improvements & Options with CodeGen Additional Improvements & Options with CodeGen + Dropping Ruby 1.9 Aug 9, 2021
@Mayurifag
Copy link

Mayurifag commented Dec 7, 2021

I wish to have zeitwerk support of generated files for ruby clients by default or to have better instructions if its presented already, — rails 7 going to be released soon

@arthurnn
Copy link
Owner

@OmriSama I think it might be interesting. Do you have time to do a PR suggestion with your changes?

@phantomwhale
Copy link

Came here to see what was being done around Zeitwerk as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants