Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FORMAT_RFC3339_STRICT. #1201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add FORMAT_RFC3339_STRICT. #1201

wants to merge 2 commits into from

Conversation

krisfremen
Copy link
Member

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Adds a FORMAT variable for a more strict RFC3339 where the RFC called for a space for readability and is used by FORMAT_RFC3339, FORMAT_RFC3339_STRICT uses the T separator to adhere with ISO8601 spec.

RFC Link

      NOTE: ISO 8601 defines date and time separated by "T".
      Applications using this syntax may choose, for the sake of
      readability, to specify a full-date and full-time separated by
      (say) a space character.

Closes #1138

@krisfremen krisfremen self-assigned this Nov 6, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (403c29f) to head (f13d917).
Report is 11 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #1201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2324      2335   +11     
  Branches       357       357           
=========================================
+ Hits          2324      2335   +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadchaar jadchaar Awaiting requested review from jadchaar

@anishnya anishnya Awaiting requested review from anishnya

At least 1 approving review is required to merge this pull request.

Assignees

@krisfremen krisfremen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "T" separator to FORMAT_RFC3339
1 participant
@krisfremen