Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed_on_bn254 isn't compatible with ERC-2494 babyjub #858

Open
TheFrozenFire opened this issue Sep 19, 2024 · 0 comments
Open

ed_on_bn254 isn't compatible with ERC-2494 babyjub #858

TheFrozenFire opened this issue Sep 19, 2024 · 0 comments

Comments

@TheFrozenFire
Copy link

I've been porting my circom/snarkjs circuits to arkworks, and found that the implementation of ed_on_bn254 isn't compatible with the curve as described in ERC-2494, in the iden3 js-crypto library, and in the circomlib circuits.

Particularly, the TECurveConfig specifies an a coefficient of 1, calculates the d coefficient in some manner I'm not familiar with, and specifies an affine generator which is different from the spec. The MontCurveConfig is similarly different in specifying the b coefficient as 1.

By "fixing" the coefficients, and using the base 8 point, I get the same outputs as js-crypto and circomlib produce.

Is there some logic underlying the difference in arkworks' implementation of babyjub?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant