Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Support ESI for pe routers #4729

Open
1 task done
gmuloc opened this issue Nov 15, 2024 · 0 comments
Open
1 task done

Feat(eos_designs): Support ESI for pe routers #4729

gmuloc opened this issue Nov 15, 2024 · 0 comments
Labels
type: enhancement New feature or request

Comments

@gmuloc
Copy link
Contributor

gmuloc commented Nov 15, 2024

Enhancement summary

Right now when using PE routers this line is blocking generation because PEs are not VTEP:

https://github.com/aristanetworks/avd/blob/devel/python-avd/pyavd/_eos_designs/structured_config/connected_endpoints/utils.py#L101

Which component of AVD is impacted

eos_designs

Use case example

interface Port-Channel1
   description L2_sw1-mrv499_Port-Channel1
   no shutdown
   bgp session tracker EVPN_SESSION_TRACKER
   switchport trunk allowed vlan 100
   switchport mode trunk
   switchport
   !
   evpn ethernet-segment
      identifier 0000:0000:a743:abac:5eae
      route-target import a7:43:ab:ac:5e:ae
   lacp system-id a743.abac.5eae
!

Describe the solution you would like

Relax the check to also accept this scenario

hacked like this for POC purposeS:

 if len(set(adapter["switches"])) < 2 or not self.shared_utils.overlay_evpn or not (self.shared_utils.overlay_vtep or self.shared_utils.overlay_ler):

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@gmuloc gmuloc added the type: enhancement New feature or request label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant