Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(cv_tags_v3): Tags module errors if the device isn't in the inventory #718

Open
1 task done
colinmacgiolla opened this issue Nov 4, 2024 · 0 comments
Open
1 task done
Labels
type: bug Something isn't working

Comments

@colinmacgiolla
Copy link
Contributor

Issue Summary

Other modules have the concept of a loose or strict inventory_mode to allow missing devices to be ignored. But the tags module does not, so we error when trying to tag devices that are not yet deployed e.g.

fatal: [XXX]: FAILED! => {"changed": false, "msg": "Error, Device leaf-1a doesn't exists on CV. Check the hostname/fqdn"}

I'd expect that the cv_tags_v3 behave similarly to the other modules, and allow missing devices to be ignored.

Which component(s) of AVD impacted

cv_tag_v3

How do you run AVD ?

Ansible CLI (with virtual-env or native python)

Input variables

vars:
   CVP_TAGS:
      - device: NOT_EXISTNG
        device_tags:
          - name: topology_hint_datacenter
            value: DC_ALPHA
          - name: topology_hint_type
            value: leaf
          - name: topology_hint_pod
            value: POD_C
          - name: topology_hint_rack
            value: 20

Steps to reproduce

Try to tag a device that doesn't yet exist

Relevant log output

fatal: [XXX]: FAILED! => {"changed": false, "msg": "Error, Device leaf-1a doesn't exists on CV. Check the hostname/fqdn"}

Code of Conduct

  • I agree to follow this project's Code of Conduct
@colinmacgiolla colinmacgiolla added the type: bug Something isn't working label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant