Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI rendering fails if clearing template #8715

Closed
tooptoop4 opened this issue May 11, 2022 · 7 comments · May be fixed by #13856
Closed

UI rendering fails if clearing template #8715

tooptoop4 opened this issue May 11, 2022 · 7 comments · May be fixed by #13856
Labels
area/ui problem/stale This has not had a response in some time type/bug

Comments

@tooptoop4
Copy link
Contributor

  1. click 'workflow templates'
  2. click 'create new workflow template'
  3. highlight the text as shown below then press 'DELETE' or 'Backspace' key on keyboard

image
5. observe the error:
image

@alexec
Copy link
Contributor

alexec commented May 11, 2022

This is probably one of these places:

https://github.com/argoproj/argo-workflows/search?l=TSX&q=workflowMetadata

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Jun 12, 2022
@tooptoop4
Copy link
Contributor Author

crispy

@stale stale bot removed the problem/stale This has not had a response in some time label Jun 15, 2022
@alexec
Copy link
Contributor

alexec commented Jun 15, 2022

@tooptoop4 would you like to submit a PR to fix this? You probably just need to fix this:

                        {template?.spec && <LabelsAndAnnotationsEditor
                            value={template.spec.workflowMetadata}
                            onChange={workflowMetadata => onChange({...template, spec: {...template.spec, workflowMetadata}})}
                        />}

@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Jul 10, 2022
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

@stale stale bot closed this as completed Aug 13, 2022
@tooptoop4
Copy link
Contributor Author

@alexec can u reopen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui problem/stale This has not had a response in some time type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants