Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide limit on the Message.Size that the Azure Message Pump can process #114

Open
stijnmoreels opened this issue Sep 8, 2020 · 2 comments
Labels
area:message-processing All issues related to how we process the messages area:security All issues related to security enhancement New feature or request feature-request All issues related to feature requests by customers integration:service-bus All issues concerning integration with Azure Service Bus

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
Maybe we should provide the possibility to provide a maximum size limit in the Azure Service Bus message pump options that can be checked before we go through the message handling logic and maybe overload parsing/deserialization/... It can be an safety check on malicious attempts.
It can then maybe be processed by a fallback message handler instead?

Describe the solution you'd like
A size limit (maybe represent metric units (KB, MB, ...) with an enumeration) in the Azure Service Bus message pump options.

Describe alternatives you've considered
Each message pump implementation and/or message handler should handle and be careful of sizes before parsing.

Additional context
When implementing the CloudEvents background job, we can use this feature to set an appropriate size limit there.
See https://github.com/cloudevents/spec/blob/master/spec.md#size-limits.

@stijnmoreels stijnmoreels added enhancement New feature or request feature-request All issues related to feature requests by customers integration:service-bus All issues concerning integration with Azure Service Bus area:message-processing All issues related to how we process the messages area:security All issues related to security labels Sep 8, 2020
@tomkerkhove
Copy link
Contributor

I haven't heard about the need for that but we can definitely keep it open to see if there is demand for it.

It has value but is very niche. I presume this would be an optional flag?

@stijnmoreels
Copy link
Member Author

I haven't heard about the need for that but we can definitely keep it open to see if there is demand for it.

OK!

It has value but is very niche. I presume this would be an optional flag?

Yeah, this could be an optional long or something that we can set on the options of the pump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:message-processing All issues related to how we process the messages area:security All issues related to security enhancement New feature or request feature-request All issues related to feature requests by customers integration:service-bus All issues concerning integration with Azure Service Bus
Projects
None yet
Development

No branches or pull requests

2 participants