Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLoopStructures() shouldn't return a pointer #164

Open
fsossai opened this issue Sep 7, 2024 · 0 comments
Open

getLoopStructures() shouldn't return a pointer #164

fsossai opened this issue Sep 7, 2024 · 0 comments
Assignees
@fsossai
Labels
enhancement New feature or request

Comments

@fsossai
Copy link
Contributor

fsossai commented Sep 7, 2024

The function Noelle::getLoopStructures() and its overloads currently return a std::vector<...>*. The correct return type should not a pointer type but std::vector<...> as this is often times source of memory leak on the user side.
@fsossai fsossai added the enhancement New feature or request label Sep 7, 2024
@fsossai fsossai self-assigned this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsossai fsossai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fsossai