Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is impossible to use custom extended ElementFactory #69

Closed
Igryk1990 opened this issue Nov 15, 2019 · 1 comment · Fixed by #75
Closed

It is impossible to use custom extended ElementFactory #69

Igryk1990 opened this issue Nov 15, 2019 · 1 comment · Fixed by #75

Comments

@Igryk1990
Copy link

If I want to create a class that extends 'ElementFactory' (e.g. I need to use method to find elements with wait), I cannot use this class in classes extend 'Form'.
@mialeska
Copy link
Contributor

This would be fixed with #75 (with release of version 2.0.0), taking advantage of DI.

@mialeska mialeska mentioned this issue Feb 21, 2020
Merged
mialeska added a commit that referenced this issue Feb 26, 2020
@mialeska
Reference aquality.selenium.core to release version 2.0.0 (#75)
6f282e0 
* rename BrowserManager to AqualityServices,
extend it from aquality.selenium.core.applications.AqualityServices.

*Change timeout in Browser from Long to Duration. 

* Add BrowserModule.

* remove some configurations, replaced with core impl

* get rid of JsonFile, migrate to JsonSettingsFile

* refactor element services to use core implementations
removed Logger, ElementFinder, enums, interfaces

* restored logging in ElementStateProvider

* Removed LocalizationManager and ConditionalWait

* Removed/Replaced ElementActionRetrier

* reworked configuration usage

* replaced container of browser factory with instance field

* add element cache configuration into json

* add missed localization values

* control localization values, restore some usages

* refactor driver settings

* Update library self-version in pom file

closes #55, closes #60, closes #66, fixes #69, fixes #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/reference aquality.selenium.core aquality-automation/aquality-selenium-java
2 participants
@mialeska @Igryk1990