From 974cf902d38ce013229641de2fec39151344ff6b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alaksiej=20Miale=C5=A1ka?=
 <mialeska@users.noreply.github.com>
Date: Wed, 16 Oct 2024 12:11:08 +0200
Subject: [PATCH] Update to Selenium 4.25.0 (#147) +semver:feature

* Update to Selenium 4.25.0 +semver:feature

* Update ChromeDownloadsForm.java

* Add waiting to stabilize testHiddenElementsNotDisplayed
---
 pom.xml                                                     | 6 +++---
 src/test/java/forms/ChromeDownloadsForm.java                | 2 +-
 .../tests/integration/elements/HiddenElementsTests.java     | 3 ++-
 .../java/tests/usecases/devtools/DeviceEmulationTest.java   | 4 ++--
 .../tests/usecases/devtools/NetworkSpeedEmulationTest.java  | 2 +-
 .../java/tests/usecases/devtools/OverrideUserAgentTest.java | 2 +-
 6 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/pom.xml b/pom.xml
index 489e27a..3c900e0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -82,7 +82,7 @@
         <dependency>
             <groupId>com.github.aquality-automation</groupId>
             <artifactId>aquality-selenium-core</artifactId>
-            <version>4.1.0</version>
+            <version>4.2.0</version>
         </dependency>
         <dependency>
             <groupId>org.apache.commons</groupId>
@@ -92,12 +92,12 @@
         <dependency>
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>jackson-databind</artifactId>
-            <version>2.17.2</version>
+            <version>2.18.0</version>
         </dependency>
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-simple</artifactId>
-            <version>2.0.13</version>
+            <version>2.0.16</version>
             <scope>test</scope>
         </dependency>
         <dependency>
diff --git a/src/test/java/forms/ChromeDownloadsForm.java b/src/test/java/forms/ChromeDownloadsForm.java
index 8ff19ac..73e4240 100644
--- a/src/test/java/forms/ChromeDownloadsForm.java
+++ b/src/test/java/forms/ChromeDownloadsForm.java
@@ -10,7 +10,7 @@
 
 public class ChromeDownloadsForm extends Form {
     private static final String ADDRESS = "chrome://downloads/";
-    public static final By NESTED_SHADOW_ROOT_LOCATOR = By.id("moreActionsMenu");
+    public static final By NESTED_SHADOW_ROOT_LOCATOR = By.cssSelector("cr-toolbar");
     public static final By DIV_ELEMENTS_LOCATOR = By.cssSelector("div");
 
     private final ILabel lblDownloadsToolbar = getFormLabel().findElementInShadowRoot(By.cssSelector("downloads-toolbar"), "Downloads toolbar", ILabel.class);
diff --git a/src/test/java/tests/integration/elements/HiddenElementsTests.java b/src/test/java/tests/integration/elements/HiddenElementsTests.java
index bebe1e8..c2f0414 100644
--- a/src/test/java/tests/integration/elements/HiddenElementsTests.java
+++ b/src/test/java/tests/integration/elements/HiddenElementsTests.java
@@ -1,5 +1,6 @@
 package tests.integration.elements;
 
+import aquality.selenium.browser.AqualityServices;
 import aquality.selenium.core.elements.ElementState;
 import aquality.selenium.core.elements.ElementsCount;
 import aquality.selenium.elements.interfaces.ILabel;
@@ -56,7 +57,7 @@ public void testHiddenElementsExist(Function<ElementsCount, List<ILabel>> elemen
     public void testHiddenElementsNotDisplayed(Function<ElementsCount, List<ILabel>> elementsListProvider) {
         List<ILabel> listElements = elementsListProvider.apply(ElementsCount.MORE_THAN_ZERO);
         Assert.assertFalse(listElements.isEmpty());
-        Assert.assertTrue(listElements.stream().noneMatch(el -> el.state().isDisplayed()));
+        Assert.assertTrue(AqualityServices.getConditionalWait().waitFor(() -> listElements.stream().noneMatch(el -> el.state().isDisplayed())));
     }
 
     @Test
diff --git a/src/test/java/tests/usecases/devtools/DeviceEmulationTest.java b/src/test/java/tests/usecases/devtools/DeviceEmulationTest.java
index 54ff008..5f50fda 100644
--- a/src/test/java/tests/usecases/devtools/DeviceEmulationTest.java
+++ b/src/test/java/tests/usecases/devtools/DeviceEmulationTest.java
@@ -3,8 +3,8 @@
 import aquality.selenium.browser.AqualityServices;
 import aquality.selenium.browser.devtools.EmulationHandling;
 import com.google.common.collect.ImmutableMap;
-import org.openqa.selenium.devtools.v128.emulation.Emulation;
-import org.openqa.selenium.devtools.v128.emulation.model.DisplayFeature;
+import org.openqa.selenium.devtools.v129.emulation.Emulation;
+import org.openqa.selenium.devtools.v129.emulation.model.DisplayFeature;
 import org.testng.Assert;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
diff --git a/src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java b/src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java
index 59f88c3..1aaeef6 100644
--- a/src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java
+++ b/src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java
@@ -2,7 +2,7 @@
 
 import aquality.selenium.browser.AqualityServices;
 import org.openqa.selenium.TimeoutException;
-import org.openqa.selenium.devtools.v128.network.model.ConnectionType;
+import org.openqa.selenium.devtools.v129.network.model.ConnectionType;
 import org.testng.Assert;
 import org.testng.annotations.Test;
 import tests.BaseTest;
diff --git a/src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java b/src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java
index b94354a..b6e595b 100644
--- a/src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java
+++ b/src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java
@@ -8,7 +8,7 @@
 import manytools.BrowserLanguageForm;
 import manytools.UserAgentForm;
 import org.openqa.selenium.devtools.idealized.Network;
-import org.openqa.selenium.devtools.v128.emulation.Emulation;
+import org.openqa.selenium.devtools.v129.emulation.Emulation;
 import org.testng.Assert;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;