Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple redirect URIs support #4

Open
TomUdr opened this issue Jun 14, 2019 · 3 comments
Open

Multiple redirect URIs support #4

TomUdr opened this issue Jun 14, 2019 · 3 comments

Comments

@TomUdr
Copy link

TomUdr commented Jun 14, 2019

It would be nice if you add support for multiple redirect URIs.
CLIENT_REDIRECT_URI could handle e.g. comma separated values.

@jits
Copy link
Contributor

jits commented Jun 14, 2019

Sounds like a potentially good idea, @TomUdr – I'd be curious to hear a use case for this, if you have one?

In theory, since this is designed purely for development and CI purposes, it should only need a single redirect URI.

@TomUdr
Copy link
Author

TomUdr commented Jun 14, 2019

We're using multi-tenant auth gateway which is handling multiple IDPs. For different tenants I would have to deploy different Mock OIDC servers with different CLIENT_REDIRECT_URIs. Which is of course doable, I'm just pointing to fact that underlaying https://github.com/panva/node-oidc-provider supports this.

@jits
Copy link
Contributor

jits commented Jun 14, 2019

Yep, node-oidc-provider definitely supports this… however this wrapper is a fairly opinionated use of it.

That is not say we won't add/support this capability – just would like to understand the case better: with the handling of multiple IdPs the mock OIDC server would still redirect to just localhost (for local dev) or whatever host is setup in CI (in which case CI config could be different for it) – is there more to it than this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants