Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]-[658]:Add Alt-Text property for Image widget #13383

Open
1 task done
GreenFlux opened this issue Apr 27, 2022 · 8 comments · May be fixed by #37371
Open
1 task done

[Feature]-[658]:Add Alt-Text property for Image widget #13383

GreenFlux opened this issue Apr 27, 2022 · 8 comments · May be fixed by #37371
Assignees
Labels
Enhancement New feature or request Image Widget Medium Issues that frustrate users due to poor UX Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@GreenFlux
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Summary

This feature request is for an Alt-Text property for all widgets, which will display when the widget's visibility is set to hidden. The value could also be used to provide Alt-Text to the browser for Image widgets, and improve Appsmith's accessibility.

Why should this be worked on?

When a widget is set to hidden, the canvas is empty in that area and nothing else can be displayed in its place to communicate to the user why a certain feature/function is missing in their app. Another widget can be used to display a message to the user, but since widgets can't be stacked it just takes up more 'real estate' in the page. The empty space from the hidden widget would be the ideal place for this type of message to the user.

@somangshu
Copy link
Contributor

@GreenFlux how is Alt-text relevant to all the widgets, I see the use case for image widget only right now

@Nikhil-Nandagopal
Copy link
Contributor

+1 it should only be for image widgets

@somangshu
Copy link
Contributor

Assuming the people that faced error with the image URL might have found the ALT-text helpful

Stats

Stat Values
Reach 658
Effort (months) 0.5

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Feature]: Add Alt-Text property for all widgets, display Alt-Text when widget is hidden [Feature]-[658]:Add Alt-Text property for all widgets, display Alt-Text when widget is hidden Apr 29, 2022
@somangshu somangshu added the Medium Issues that frustrate users due to poor UX label Apr 29, 2022
@GreenFlux
Copy link
Author

@GreenFlux how is Alt-text relevant to all the widgets, I see the use case for image widget only right now

Actually, I'm requesting an alternative text to be displayed for ANY widget, when that widget is set to hidden. Since that leaves an empty place on the canvas, this seems like the ideal place to display a message about why any type of widget has been hidden.

I'm suggesting that this feature could also be used for images- in the more traditional alt-text way, but really it's for all widgets when they have been hidden by a JS condition and we want to provide a message to the user it its place.

Perhaps calling it alt-text is confusing. Maybe this should be called 'Hidden Message' instead. But I think this feature would be useful for all widgets, which is my primary request. The use of this text as an image's alt-text is more of an added bonus for this feature.

Use Cases:

  • Button has been hidden by JS because conditions are not met. Alt-Text displays explanation to user, prompting to fill out required form.
  • Child table is hidden because a row has not been selected in the parent table. Message can be displayed in place of child table while it is hidden, prompting user to select row on parent table.

The empty space on the canvas is the most logical place to display a message about why a widget has been hidden, but we can't stack widgets. If we had a property to provide an alternative text it its place then any hidden widget could inform the user of what conditions are causing the feature to be disabled.

@Nikhil-Nandagopal
Copy link
Contributor

@GreenFlux web apps don't usually have hidden messages right? The request seems more like a patch because of the whitespace that is occupied when actually we should simply solve the problem that if a widget is not visible, it should not take up space. What do you think?

@GreenFlux
Copy link
Author

Yes, that would address the issue as well. I actually considered requesting that instead, but I thought that displaying text in place of the hidden widget would be easier than having other widgets adjust their size and position when another widget is hidden. But if moving other widgets is a feasible fix on your end, that would work as well.

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Feature]-[658]:Add Alt-Text property for all widgets, display Alt-Text when widget is hidden [Feature]-[658]:Add Alt-Text property for Image widget May 2, 2022
@Nikhil-Nandagopal
Copy link
Contributor

@GreenFlux yes we're working on enabling that as part of the dynamic height project

@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
@vhemery
Copy link
Contributor

vhemery commented Nov 12, 2024

I would like to contribute a PR which adds an "alt" text property to the image widget (with tests).
This PR addresses only the "alt" property for accessibility, to display in the alt HTML attribute. It does nothing when widget is hidden and has nothing to do with the dynamic height project.

@Nikhil-Nandagopal
Should I link this PR to this feature issue or assign it to another new feature issue?

vhemery pushed a commit to bonitasoft-labs/appsmith that referenced this issue Nov 13, 2024
Add the alt attribute as a new widget property

Fixes [appsmithorg#13383](appsmithorg#13383)
vhemery added a commit to bonitasoft-labs/appsmith that referenced this issue Nov 13, 2024
@vhemery vhemery linked a pull request Nov 13, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Image Widget Medium Issues that frustrate users due to poor UX Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants