Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next steps for mono #1

Closed
7 tasks done
tombruijn opened this issue Apr 2, 2021 · 2 comments
Closed
7 tasks done

Next steps for mono #1

tombruijn opened this issue Apr 2, 2021 · 2 comments
Assignees

Comments

@tombruijn
Copy link
Member

tombruijn commented Apr 2, 2021

The current committed state is a prototype and ⚠️ will not work ⚠️ because I stubbed out certain commands for safety. Before we start using it we should add basic tests for all commands so that we're sure of what it does in what order.

Previous tracking issue: https://github.com/appsignal/appsignal-agent/issues/678

  • Testing
    • First implement basic tests for all commands. ⚠️ It would be unsafe to continue development without testing ⚠️
  • Set up CI build
  • Add npm/yarn link to packages on mono bootstrap
  • Figure out the best order for build and publish
    • Can packages in all languages use the same build order (commit, build, publish) or do they require the build before commit (build, commit, publish). For Ruby you get a warning about the changeset files not being found that were committed in git, but maybe the changeset should be ignored in the gemspec file to avoid that from happening?
    • gem.files         = `git ls-files`.split($\).reject { |f| f.start_with?(".changesets/") }
      
  • Add confirmation prompt before actually publishing with mono publish
    • The mono publish command will print a summary of what it will do and then immediately do it. It would be good to prompt the user for a confirmation first, before publishing.
  • Support prereleases (alpha, beta, rc, etc)
    • Probably best with a command flag: mono publish --alpha/beta/rc
  • Standardize clean command
    • Does it only clean the project and its dependencies
    • Or also clean the AppSignal extension files? (probably best to implement this as a hook, but then the AppSignal integrations need to have tasks for mono to call in a pre/post hook).
@tombruijn tombruijn self-assigned this Apr 2, 2021
@tombruijn tombruijn changed the title Next steps Next steps for mono Apr 2, 2021
@backlog-helper
Copy link

While performing the daily checks some issues were found with this issue.

  • This issue has not had any activity in 14 days. Please provide a status update if it is still relevant. Closed it if it is no longer relevant. Or move it to another column if it's blocked or requires another look at it. - (More info)

New issue guide | Backlog management | Rules | Feedback

@tombruijn
Copy link
Member Author

Split out some issues into #5 and #6, but it's working enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant