Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add absinthe support #751

Closed
2 of 4 tasks
tombruijn opened this issue Jan 24, 2022 · 4 comments · Fixed by #834
Closed
2 of 4 tasks

Add absinthe support #751

tombruijn opened this issue Jan 24, 2022 · 4 comments · Fixed by #834
Assignees

Comments

@tombruijn
Copy link
Member

tombruijn commented Jan 24, 2022

Support the absinthe library.

To do

Requests

@tombruijn
Copy link
Member Author

tombruijn commented Jan 31, 2022

Let's look at the opentelemetry integration viability first: https://github.com/appsignal/integration-guide/issues/47 (private issue). Which is currently in progress.

@haizop
Copy link

haizop commented Aug 15, 2022

@tombruijn Any update on this? AppSignal would be a lot more useful for my team if it worked properly for Absinthe.

@tombruijn
Copy link
Member Author

@haizop so far no update. It's not on our immediate roadmap. If we were to implement something now to instrument Absinthe, we would not be able to instrument it fully. A feature like asynchronous field resolution would not be supported.

We hope to adopt OpenTelemetry in our Elixir integration, improve the async support, and write an Absinthe instrumentation if it doesn't exist at that time.

For now we recommend writing your own instrumentation so you have more control over how it gets instrumented.

I have previously written a page in our docs for some middleware that does basic support, but I hesitate to link it because it should not be considered a full integration. I don't even know if it would still work.

@tombruijn
Copy link
Member Author

tombruijn commented Jun 26, 2023

Absinthe support was added in appsignal package version 2.7.0 🚀
Docs: https://docs.appsignal.com/elixir/integrations/absinthe.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants