You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm in favor of getting this out quickly to unblock Juniper.
Longer term, we probably want to consider some things:
instead of adding our stuff directly to openedx.core.storage.ProductionS3Storage, we probably ought to make our own storage class that just subclasses it to override url() and add the explicit caching, then use AppsemblerProductionS3Storage in our config.
having honeycomb tracing on every call to url() is useful at the moment for debugging/verifying this fix, but is probably more verbose than we're going to want to dial it down later.
instead of commenting out the setting of the key prefix here and putting a random value in the config in appsembler/configuration#361 maybe we could instead set EDX_PLATFORM_REVISION to a git hash or cloud build revision id during the deploy (with something like an ansible --extra-vars=EDX_PLATFORM_REVISION=$REVISION_ID in the deploy script. That would achieve the same effect of making sure that the cache is cleared on each deploy.
The text was updated successfully, but these errors were encountered:
OmarIthawi
changed the title
Tests for: Enforce static file look up for ProductionS3Storage backend
Tests and refactoring for: Enforce static file look up for ProductionS3Storage backend
May 12, 2021
Add tests for the Juniper production s3 cache: Enforce static file look up for ProductionS3Storage backend #907
Address Anders comment: Enforce static file look up for ProductionS3Storage backend #907 (review)
The text was updated successfully, but these errors were encountered: