Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and refactoring for: Enforce static file look up for ProductionS3Storage backend #912

Open
OmarIthawi opened this issue May 11, 2021 · 0 comments

Comments

@OmarIthawi
Copy link

OmarIthawi commented May 11, 2021

  1. Add tests for the Juniper production s3 cache: Enforce static file look up for ProductionS3Storage backend #907

  2. Address Anders comment: Enforce static file look up for ProductionS3Storage backend #907 (review)

I'm in favor of getting this out quickly to unblock Juniper.

Longer term, we probably want to consider some things:

  • instead of adding our stuff directly to openedx.core.storage.ProductionS3Storage, we probably ought to make our own storage class that just subclasses it to override url() and add the explicit caching, then use AppsemblerProductionS3Storage in our config.
  • having honeycomb tracing on every call to url() is useful at the moment for debugging/verifying this fix, but is probably more verbose than we're going to want to dial it down later.
  • instead of commenting out the setting of the key prefix here and putting a random value in the config in appsembler/configuration#361 maybe we could instead set EDX_PLATFORM_REVISION to a git hash or cloud build revision id during the deploy (with something like an ansible --extra-vars=EDX_PLATFORM_REVISION=$REVISION_ID in the deploy script. That would achieve the same effect of making sure that the cache is cleared on each deploy.
@OmarIthawi OmarIthawi changed the title Tests for: Enforce static file look up for ProductionS3Storage backend Tests and refactoring for: Enforce static file look up for ProductionS3Storage backend May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant