Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error for duplicate map<> keys when decoding TextFormat #1159

Open
thomasvl opened this issue Aug 2, 2021 · 0 comments
Open

Raise error for duplicate map<> keys when decoding TextFormat #1159

thomasvl opened this issue Aug 2, 2021 · 0 comments
Labels
kind/bug Feature doesn't work as expected. ⚠️ semver/major Breaks existing public API.

Comments

@thomasvl
Copy link
Collaborator

thomasvl commented Aug 2, 2021

From the Map Features section of the proto2 syntax spec.

When parsing from the wire or when merging, if there are duplicate map keys the last key seen is used. When parsing a map from text format, parsing may fail if there are duplicate keys.

The second sentence there is the key. Right now Swift doesn't do this, but there seems to be some rumblings that this might get fixed in other languages and added to the conformance test.
@thomasvl thomasvl added kind/bug Feature doesn't work as expected. ⚠️ semver/major Breaks existing public API. labels Apr 7, 2022
@thomasvl thomasvl mentioned this issue Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Feature doesn't work as expected. ⚠️ semver/major Breaks existing public API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomasvl