Update Examples and IntegrationTest to use idiomatic naming #706
+244
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
approved these changes
Dec 19, 2024
Examples/tracing-middleware-example/Sources/HelloWorldVaporServer/HelloWorldVaporServer.swift
Show resolved
Hide resolved
…ver/HelloWorldVaporServer.swift Co-authored-by: Si Beaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since idiomatic naming is our new recommended setting, use it in Examples and IntegrationTest.
Modifications
Added idiomatic naming to all examples and made any necessary changes. Plus a few modernizations, like moving to Hummingbird 2.0 and to Prometheus 2.0.
Result
More up-to-date examples, easier to copy out by adopters, they now get our recommended starting settings.
Test Plan
Ran and tested locally.