Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisite steps to the client example documentation #703

Conversation

brentvegafederal
Copy link

Motivation

I got a bit tripped up running this example and wanted to fix the documentation to help others.

Modifications

Updated the README file to be a bit clearer.

Added clearer instructions for starting the server before running the clients.
Added a line showing server response
Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thank you!

@simonjbeaumont simonjbeaumont changed the title Readme update Add prerequisite steps to the client example documentation Dec 17, 2024
@simonjbeaumont simonjbeaumont added the semver/none No version bump required. label Dec 17, 2024
@simonjbeaumont
Copy link
Collaborator

But doesn’t this doc already say this?

The server can be started by running any of the Hello World server examples locally.

@czechboy0
Copy link
Contributor

Yes I missed it too, closing.

@czechboy0 czechboy0 closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants