Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport observer should be aware of accepted inactive channels #1755

Open
tkountis opened this issue Aug 26, 2021 · 0 comments
Open

Transport observer should be aware of accepted inactive channels #1755

tkountis opened this issue Aug 26, 2021 · 0 comments

Comments

@tkountis
Copy link
Contributor

We recently added support for 'stop-accepting' connections on the server through an API.
When this is used, it allows connections to establish (3-way handshake) and then remain in the accept_queue (i.e. SO_BACKLOG) until they are accepted by the server. This of course depends on the setting for the backlog.
Connections waiting to be accepted may become inactive for various reasons e.g. client timeouts. When we accept them we check the state of the channel before making any progress with it and drop them otherwise. Its worth adding visibility for this behaviour in TransportObserver.

discussion: #1741 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant