From a12a0bf93a21a57e721b8a0d0222007dd864ddb6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABl=20Nison?= Date: Wed, 27 Nov 2019 16:11:00 +0100 Subject: [PATCH] a-e-r: Add missing peer dependency on `graphql`. (#3496) * Adds missing peer dependency * Widen `peerDependencies` range to match other Apollo packages' ranges. The `apollo-engine-reporting` package was absolutely missing its `peerDependencies` specification for `graphql`. The previous commit added it, but we also need to expand it to match the same range as suggested by the rest of the Apollo packages in the Apollo Server monorepo. Ref: https://git.io/JeXBd * Add CHANGELOG.md for #3496. --- CHANGELOG.md | 1 + packages/apollo-engine-reporting/package.json | 3 +++ 2 files changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 69e4fc93949..3270b01aaa1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ The version headers in this history reflect the versions of Apollo Server itself > The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the the appropriate changes within that release will be moved into the new section. - `@apollo/gateway`: Add `@types/node-fetch` as a regular dependency to avoid missing dependency for TypeScript consumers. [PR #3546](https://github.com/apollographql/apollo-server/pull/3546) [Issue #3471](https://github.com/apollographql/apollo-server/issues/3471) +- `apollo-engine-reporting`: Declare acceptable `graphql` versions ranges in `peerDependencies` rather than allowing it to occur implicitly (and less ideally) via its consumers (e.g. most `apollo-server-*` packages). [PR #3496](https://github.com/apollographql/apollo-server/pull/3496) ### v2.9.12 diff --git a/packages/apollo-engine-reporting/package.json b/packages/apollo-engine-reporting/package.json index 725613dd01a..4dc9813744a 100644 --- a/packages/apollo-engine-reporting/package.json +++ b/packages/apollo-engine-reporting/package.json @@ -18,5 +18,8 @@ "apollo-server-types": "file:../apollo-server-types", "async-retry": "^1.2.1", "graphql-extensions": "file:../graphql-extensions" + }, + "peerDependencies": { + "graphql": "^0.12.0 || ^0.13.0 || ^14.0.0" } }