Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO comments #579

Open
CoolKangaroo2022 opened this issue Aug 15, 2021 · 0 comments
Open

TODO comments #579

CoolKangaroo2022 opened this issue Aug 15, 2021 · 0 comments

Comments

@CoolKangaroo2022
Copy link

CoolKangaroo2022 commented Aug 15, 2021

Hello! I find in your CONTRIBUTING.md that

Don't leave TODOs in the code or FIXMEs if you can help it.

However, I still witness some TODO comments, e.g., unfinished Javadoc for the class in ObjectType.java .
I also find TODO comments in the following files:

  • game/src/main/java/org/apollo/game/model/skill/LevelUpSkillListener.java
  • game/src/main/java/org/apollo/game/model/area/Region.java
  • game/src/main/java/org/apollo/game/session/ApolloHandler.java
  • game/src/main/java/org/apollo/game/service/GameService.java
  • game/src/main/java/org/apollo/game/plugin/PluginManager.java
    ......

Would you like to remove these TODO comments, or move them to issues, or just leave them alone?
If there is anything I can help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant