Shop Timers for items need to be refreshed every tick for items

[WizardJesse1]

• Basically each item has its own set timer of how long it takes to restock.

Currently from what I saw the shops are being refreshed every 100 ticks instead. Its a pretty straight out issue but if more detail is needed I can go into it.

To add on to this I believe there is also a default timer though that they use for items that do not belong in the shop

eg. General store and selling a whip.

[tlf30]

@WizardJesse1 can you provide where you found that each item has its own restock timer. I have not found that anywhere in my research.

[WizardJesse1]

@tlf30 if you simply go on you would see.

restocking a item for like bronze arrows would be faster then adamant arrows at lowe range shop in varrock

[garyttierney]

I think @WizardJesse1 is correct. I don't expect adamant arrows to replenish at the same rate as bronze arrows.

[Major-]

Shops were changed significantly between 377 and OSRS. Are we sure the behaviour is the same? Afaik @tlf30 is correct with respect to 3xx

[WizardJesse1]

The only time I remember them changing timers for runescape was in rs3 era and that was when shops were fully restocked every 24hrs and each player had there own unique shop

[cadamsdev]

Each individual shop item can have its own restock rate.
https://twitter.com/JagexAsh/status/934501991518212097

[tlf30]

@nshusa is that for osrs or 3xx?

[tlf30]

It does not really matter to me which way we do it, I just want to make sure that we are going for the most historically accurate way. I know a lot has changed since 3xx up to the current osrs. I personally like having a timer for each item, it makes more sense, but I do not believe that is how it was done in 317/377. On the other hand, that was many years ago and I am not known for having a good memory.

[Major-]

I'm also not bothered as long as restocking is reasonable

[cadamsdev]

@tlf30 Old school. Even if they did change how shops are done I don't see a reason to use the old system.

[garyttierney]

One reason would be correctness. If the old system used a shared timer then that's what we should do.

[rmcmk]

Impossible to know, really. Such a minuscule feature that I doubt anyone remembers the specific functionality. I vote go with the OSRS mechanics. As far as I'm aware they haven't changed since its existence. I'm fairly certain that mechanic has always been the same since the interface overhaul at least.

[Tomm0017]

@Major- @garyttierney Has there been a final decision made on this? I don't think any more discussion will do any good as no one is able to actually prove what rev. 377 did regarding this situation. If I had to make a guess, I would say they did have the ability to set different timers for each item. Someone on the development team should just make a decision to either close this or allow a PR to be made for it.

[Major-]

Let's implement the OSRS behaviour (stated below), meaning this issue is valid and stays open.

Each individual shop item can have its own restock rate.

https://twitter.com/JagexAsh/status/934501991518212097: Individual stacks in individual shops can have different restock rates. I don't know exactly how the engine's handling it under the hood though.