Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.0 redirects after sign out on an XHR request #204

Open
aaronjensen opened this issue Sep 10, 2021 · 4 comments
Open

1.7.0 redirects after sign out on an XHR request #204

aaronjensen opened this issue Sep 10, 2021 · 4 comments

Comments

@aaronjensen
Copy link

I'm not able to provide a repro at the moment, but after upgrading to 1.7.0 from 1.6.3, our sign out API request results in a 302, rather than a 200. I suspect this commit: 27b531e

@adamstegman
Copy link
Collaborator

Interesting. I would suspect the before_action is stepping in and redirecting, where there was nothing before. You could skip it or redefine it to have different behavior.

@mattbaumann1
Copy link
Contributor

mattbaumann1 commented Jul 27, 2022

We recently upgraded to v1.7.0 and started having this issue. I decided to push it to v1.9.0 with the hopes it would be fixed and ended up with the same. Logs show a 302 and saml-tracer shows a 400.

Are others still having this issue?
@aaronjensen
@adamstegman

@mattbaumann1
Copy link
Contributor

I think this is going to be a cross-site issue that will include the installation of gem 'rack-cors'. Is this what was required for others?

@mattbaumann1
Copy link
Contributor

For us this ended up being an issue with turbo_stream reloading not loading the necessary headers and a CORS error being thrown, so not associated with the devise_saml_authenticatable upgrade but the fact that we added turbo at the same time.
NUARIG/competitions#964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants