Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala tokenizer depends on the outdated library Scalariform #33

Open
markkuriekkinen opened this issue Feb 15, 2022 · 0 comments
Open
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@markkuriekkinen
Copy link
Contributor

markkuriekkinen commented Feb 15, 2022

The Scalariform library used in the Scala tokenizer has not been maintained since 2019.

In the commit 9e035e0, I updated the Scalariform library used to parse and tokenize the student's submitted Scala code. However, Scalariform has not been maintained since June 2019. I am not sure if the latest version fully supports parsing Scala 2.13 code. At least, Scalariform source code contains constants for Scala versions and the highest is Scala 2.11:
https://github.com/scala-ide/scalariform/blob/0.2.10/scalariform/src/main/scala/scalariform/ScalaVersions.scala#L38

Scalariform docs say that v0.2.10 supports Scala 2.13, but that might refer to compiling and running the library on Scala 2.13. Parsing input code is a different matter.

Scala 3 changes the syntax of the language. In order to tokenize Scala 3, we most definitely need a new solution since Scalariform will never support Scala 3.

Related to #30.

In Radar code, the Scala tokenizer is here:

@markkuriekkinen markkuriekkinen added the dependencies Pull requests that update a dependency file label Feb 15, 2022
@Harman-Aalto Harman-Aalto self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants