Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symlink in _static #17

Open
jykesaviaGNH opened this issue Jun 11, 2020 · 2 comments
Open

symlink in _static #17

jykesaviaGNH opened this issue Jun 11, 2020 · 2 comments

Comments

@jykesaviaGNH
Copy link

_static/enrollmentquiz.js is a symbolic link.
This is problematic in environments not supporting them (at all or correctly).
Examples:

  • git checkout to filesystem with no symbolic links

  • Tampere plussa environment has a sftp/scp filecopy which does not understand symlinks

@raphendyr
Copy link
Contributor

git checkout to filesystem with no symbolic links

Git should create a copy of the file in that case. Though, if the symlink is into a submodule, then git can't work for us. In the latter case, the file should be added to conf.py to be copied (see html_extra_path).

Tampere plussa environment has a sftp/scp filecopy which does not understand symlinks

Asuming only this (not the previous), then I think the upload process should be made aware of the symlinks. Bare minimum, is that it should copy the files. It's very possible that the course would use symlinks for some files as that is an efficient way to duplicate file.

@raphendyr
Copy link
Contributor

I think the symlink should be replaced with the config value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants