Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency Between Documentation and Code Regarding Default State of enableTopicMessageTypeCheck #587

Open
QianChenJun opened this issue Aug 11, 2023 · 0 comments

Comments

@QianChenJun
Copy link
Contributor

The issue tracker is ONLY used for bug report and feature request.

Any question or RocketMQ proposal please use our mailing lists.

BUG REPORT

  1. Please describe the issue you observed:
    These files pr add some document descriptions, one about enableTopicMessageTypeCheck false by default.
    image
    but this code ProxyConfig.java defaults to true.
    private long defaultInvisibleTimeMills = Duration.ofSeconds(60).toMillis();
    private long minInvisibleTimeMillsForRecv = Duration.ofSeconds(10).toMillis();
    private long maxInvisibleTimeMills = Duration.ofHours(12).toMillis();
    private long maxDelayTimeMills = Duration.ofDays(1).toMillis();
    private long maxTransactionRecoverySecond = Duration.ofHours(1).getSeconds();
    private boolean enableTopicMessageTypeCheck = true;
  1. Please tell us about your environment:

  2. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):

RongtongJin pushed a commit that referenced this issue Jan 17, 2024
…ault (#588)

* docs: Update description about enableTopicMessageTypeCheck default

* docs: Update description about enableTopicMessageTypeCheck default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant