Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request support for pre-processing "full" when using JDK >= 23 #201

Open
jmborer opened this issue Sep 30, 2024 · 5 comments
Open

Request support for pre-processing "full" when using JDK >= 23 #201

jmborer opened this issue Sep 30, 2024 · 5 comments

Comments

@jmborer
Copy link
Contributor

jmborer commented Sep 30, 2024

As the pre-processing has changed since JDK 23 (https://inside.java/2024/06/18/quality-heads-up/) and is required by many NB platform functions, the NB Maven plugin shall force the compiler settings to:

<configuration>
      <proc>full</proc>
</configuration>

Or at least inform the user that it shall turn it to "full".

@jmborer jmborer changed the title Request support for pre-processing when using JDK >= 23 Request support for pre-processing "full" when using JDK >= 23 Sep 30, 2024
@neilcsmith-net
Copy link
Member

We should probably see if there's a way to provide a better warning. I don't think we should be changing the configuration, even if that's possible. @ebarboni what do you think on this one?

@ebarboni
Copy link
Contributor

I don't think nbm plugin can alter configuration for compiler plugin. Maybe a hint in the IDE could help as well of having a condition in archetypes to add this line according to JDK version.

@neilcsmith-net
Copy link
Member

Thanks! That's what I thought. Hint might be useful for pre-existing projects. Should move that request over to the IDE issue queue.

No need to add the archetype change according to version - should be OK to add in on all supported JDKs. There's a bunch of things that need updating in the archetypes already.

@jmborer
Copy link
Contributor Author

jmborer commented Oct 2, 2024

Indeed, this is what I would expect as well. Conditional Maven profiles could be used as well to turn on the proper flag for the compiler. This could be generated by the archetype is a non-invasive way to provide proper flags to build NB based applications.

PS: I turned the proc to "full" on my projects with JDK23 and it works as before.

@neilcsmith-net
Copy link
Member

neilcsmith-net commented Oct 2, 2024

@jmborer feel free to submit a PR for either. No need for conditional profiles - this will work fine on all supported JDKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants