Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestRandomStrings/TestRandomHugeStrings Failures #1044

Open
1 task done
paulirwin opened this issue Nov 25, 2024 · 0 comments
Open
1 task done

TestRandomStrings/TestRandomHugeStrings Failures #1044

paulirwin opened this issue Nov 25, 2024 · 0 comments

Comments

@paulirwin
Copy link
Contributor

paulirwin commented Nov 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Split out from #269

The following tests fail with enough repeated iterations:

  • Lucene.Net.Analysis.Th.TestThaiAnalyzer::TestRandomStrings()
  • Lucene.Net.Analysis.Th.TestThaiAnalyzer::TestRandomHugeStrings()
  • Lucene.Net.Analysis.Icu.TestICUTokenizerCJK::TestRandomStrings()
  • Lucene.Net.Analysis.Icu.TestICUTokenizerCJK::TestRandomHugeStrings()
  • Lucene.Net.Analysis.Icu.TestICUTokenizer::TestRandomStrings()
  • Lucene.Net.Analysis.Icu.TestICUTokenizer::TestRandomHugeStrings()

These are all due to a bug in ICU4N, fixed in NightOwl888/ICU4N#96

Once an ICU4N release is published with this fix, we can remove the [AwaitsFix] from these tests and re-enable them.

Also, as part of fixing this, we should remove the static locking in these tokenizers to improve performance.

See: #313 (comment)

Expected Behavior

The tests pass.

Steps To Reproduce

Remove [AwaitsFix] attribute from these tests, and add a [Repeat(100)] (or higher count) attribute. May require running multiple times to reproduce due to it being a concurrency bug.

Exceptions (if any)

No response

Lucene.NET Version

No response

.NET Version

No response

Operating System

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant