Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize : skip sending some request if client-version is v0 #6998

Open
wants to merge 13 commits into
base: 2.x
Choose a base branch
from
Open

optimize : skip sending some request if client-version is v0 #6998

wants to merge 13 commits into from
+222 −3

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Nov 14, 2024 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  1. 新增了客户端版本+msgType来判断是否跳过的逻辑
  2. 这个功能在sendAsync和sendSync都加上了，保证代码逻辑的一致性，但sendSync的“if”是不会进的。
  3. sendSync的时候会返回一个VersionNotSupportMessage。目前来说TC使用sendSync的逻辑不会做这种判断，后续如果有skip的情况就需要在接收的时候先判断类型，而不是直接强转。
  4. 在NettyClientChannelManager中为channel注册版本号
  1. Added client version + msgType to determine whether to skip the logic.
  2. this feature is added to both sendAsync and sendSync to ensure the consistency of code logic, but the “if” of sendSync will not be entered.
  3. sendSync will return a VersionNotSupportMessage. at present, TC use sendSync logic will not do this kind of judgment, and then if there is a skip case you need to judge the type of the first time you receive, rather than directly force the transfer.
  4. Register the version number for the channel in the NettyClientChannelManager

Translated with DeepL.com (free version)

Ⅱ. Does this pull request fix one issue?

fixes #6999

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi changed the title Optimize : Skip sending some request if client-version is v0 optimize : Skip sending some request if client-version is v0 Nov 14, 2024
@Bughue
Merge branch '2.x' of https://github.com/seata/seata into dev-2024-un…
b1af528 
…dolog-del

# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
@Bughue
style
c57ffb1
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.81481% with 23 lines in your changes missing coverage. Please review.

Project coverage is 52.58%. Comparing base (0a21dea) to head (628c965).

Files with missing lines Patch % Lines
...va/org/apache/seata/core/rpc/MsgVersionHelper.java 30.76% 7 Missing and 2 partials ⚠️
...he/seata/core/rpc/netty/AbstractNettyRemoting.java 0.00% 6 Missing and 2 partials ⚠️
.../seata/core/protocol/VersionNotSupportMessage.java 0.00% 2 Missing ⚠️
...n/java/org/apache/seata/core/protocol/Version.java 0.00% 1 Missing ⚠️
...eata/core/rpc/netty/NettyClientChannelManager.java 0.00% 1 Missing ⚠️
...he/seata/core/rpc/netty/RmNettyRemotingClient.java 0.00% 1 Missing ⚠️
...he/seata/core/rpc/netty/TmNettyRemotingClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6998      +/-   ##
============================================
- Coverage     52.60%   52.58%   -0.02%     
- Complexity     6582     6585       +3     
============================================
  Files          1126     1128       +2     
  Lines         39953    39978      +25     
  Branches       4688     4693       +5     
============================================
+ Hits          21017    21024       +7     
- Misses        16932    16946      +14     
- Partials       2004     2008       +4
Files with missing lines Coverage Δ
...n/java/org/apache/seata/core/protocol/Version.java 69.04% <0.00%> (+0.75%) ⬆️
...eata/core/rpc/netty/NettyClientChannelManager.java 59.87% <0.00%> (-0.39%) ⬇️
...he/seata/core/rpc/netty/RmNettyRemotingClient.java 52.59% <0.00%> (ø)
...he/seata/core/rpc/netty/TmNettyRemotingClient.java 72.54% <0.00%> (ø)
.../seata/core/protocol/VersionNotSupportMessage.java 0.00% <0.00%> (ø)
...he/seata/core/rpc/netty/AbstractNettyRemoting.java 49.38% <0.00%> (-2.57%) ⬇️
...va/org/apache/seata/core/rpc/MsgVersionHelper.java 30.76% <30.76%> (ø)

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@Bughue Bughue changed the title optimize : Skip sending some request if client-version is v0 optimize : skip sending some request if client-version is v0 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funky-eyes funky-eyes Awaiting requested review from funky-eyes

@slievrly slievrly Awaiting requested review from slievrly

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0-client(<0.7.1) can not decode UndoLogDeleteRequest
1 participant
@Bughue