Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21166 - Kubernetes Configmaps: Trigger context reloading on update #16279

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Nov 14, 2024

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@oscerd
Copy link
Contributor Author

oscerd commented Nov 14, 2024

@davsclaus here is the PR we were talking about, converted to draft because the task doesn't seem to run at all.

@davsclaus
Copy link
Contributor

did you have a sample camel route etc - that can help try it more easily than unit tests which seems working fine

@oscerd oscerd marked this pull request as ready for review November 15, 2024 16:04
@oscerd
Copy link
Contributor Author

oscerd commented Nov 15, 2024

I created this: https://github.com/oscerd/cm-trigger but the problem was just the need of having the camel-kubernetes dependency in the classpath. My fault. It is the second time.

@oscerd oscerd merged commit 2f8d69d into main Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants