Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add camel-observability-services #16277

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Nov 14, 2024

With this PR we're adding a new component which serves as an adapter and helper to expose a set of opinionated observability services. This first MVP adds camel-micrometer-prometheus components and a default configuration for it. Once this is onboarded I'll proceed with creating the proper extension/starter for the other runtimes.

Iteratively we'll be adding into this adapter a few more components in order to expose other sensitive observability metrics (telemetry, health, ...). The main goal is to provide services required when running a microservice oriented architecture on cloud, but the component can be used outside cloud as well with the same meaning.

Closes CAMEL-21384

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@squakez
Copy link
Contributor Author

squakez commented Nov 14, 2024

@claudio4j @oscerd FYI. I am not sure if I've missed some configuration required to onboard the new component. Just let me know.

@davsclaus
Copy link
Contributor

This looks good to me. This makes it easy by just adding the JAR and auto-configure.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@squakez squakez merged commit 88baf22 into apache:main Nov 15, 2024
4 checks passed
@squakez squakez deleted the feat/CAMEL-21384 branch November 15, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants