Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Use Duration unit with Self-optimizing Configurations #3119

Open
3 tasks done
Tracked by #3048
czy006 opened this issue Aug 20, 2024 · 4 comments
Open
3 tasks done
Tracked by #3048

[Improvement]: Use Duration unit with Self-optimizing Configurations #3119

czy006 opened this issue Aug 20, 2024 · 4 comments
Assignees
Milestone

Comments

@czy006
Copy link
Contributor

czy006 commented Aug 20, 2024

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Users need to manually calculate thousands of time / memory units every time. If it can be similar to the Apache Flink configuration, users can complete the configuration by specifying values ​​with memory units/time units, which will greatly facilitate the user experience.

for self-optimizing.minor.trigger.interval as an example

Before

  • self-optimizing.minor.trigger.interval
  • 3600000(1 hour)
  • The time interval in milliseconds to trigger minor optimizing

After

  • self-optimizing.minor.trigger.duration
  • 1hour/1day [0-9]+ (d | day | h | hour | m | min | minute | s | sec | second | ms | milli | millisecond | us | micro | microsecond | ns | nano | nanosecond)
  • Duration The time interval Duration to trigger minor optimizing

The before configuration will be removed in 0.9. We can recommend users to modify the configuration as soon as possible, and it should be noted in the upgrade log.

How should we improve?

  • add duration config support
  • add unit test with new duration config
  • Ensure compatibility of old configurations, and new configurations have higher priority

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

@czy006 czy006 added this to the Release 0.8.0 milestone Aug 20, 2024
@czy006 czy006 self-assigned this Aug 20, 2024
@czy006
Copy link
Contributor Author

czy006 commented Aug 20, 2024

cc @zhoujinsong

@zhoujinsong
Copy link
Contributor

This is a good idea to make our configuration more user-friendly.

However, we still need to discuss how to maintain compatibility with the old configuration values:

  1. Ignore the format error and use the default value
  2. Make the default unit to milliseconds and be compatibility with old values.

Besides, is this improvement affect both table properties and AMS configurations?

@czy006
Copy link
Contributor Author

czy006 commented Aug 20, 2024

This is a good idea to make our configuration more user-friendly.

However, we still need to discuss how to maintain compatibility with the old configuration values:

  1. Ignore the format error and use the default value
  2. Make the default unit to milliseconds and be compatibility with old values.

Besides, is this improvement affect both table properties and AMS configurations?

thanks for your feedback. I think this configuration will affect the table properties and AMS configuration.

If Amoro users upgrade to a higher version and do not modify the table configuration, it may not be read correctly.

Despite our best efforts to ensure compatibility, the old configuration will be removed from support after the next 2 versions (or 1.0 with amoro). We can recommend users to modify the configuration as soon as possible, and this should be noted in the upgrade log.

@Aireed Aireed mentioned this issue Dec 4, 2024
33 tasks
@klion26
Copy link
Member

klion26 commented Jan 22, 2025

Flink memory configuration has been improved by #3409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants