Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Test Commit Causes Skipped Checks or CI Failures #45902

Closed
1 of 2 tasks
missaarohi opened this issue Jan 22, 2025 · 2 comments
Closed
1 of 2 tasks

Workflow Test Commit Causes Skipped Checks or CI Failures #45902

missaarohi opened this issue Jan 22, 2025 · 2 comments
Labels
area:CI Airflow's tests and continious integration area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet

Comments

@missaarohi
Copy link

Apache Airflow version

2.10.4

If "Other Airflow 2 version" selected, which one?

No response

What happened?

The PR created for testing workflows resulted in some checks being skipped during the GitHub Actions pipeline execution. Specifically, checks such as "React UI tests," "Static checks: basic checks only," and "Build documentation (--docs-only)" were skipped, which could indicate issues with the CI configuration or dependencies missing in the environment. This is not expected behavior, as all checks should run unless explicitly excluded or intentionally skipped.

What you think should happen instead?

All the tests, including UI, static checks, and documentation checks, should run successfully without being skipped unless intentionally configured otherwise. There shouldn't be any skipped tests unless they are non-essential or have been excluded for a valid reason.

How to reproduce

  1. Create a PR with test commits designed to check the workflow (e.g., for testing CI behavior).
  2. Monitor the GitHub Actions pipeline.
  3. Observe that certain tests (e.g., React UI tests, Static checks) are skipped while others complete successfully.
  4. Investigate the CI configuration or dependencies to find potential causes.

Operating System

Ubuntu

Versions of Apache Airflow Providers

#output
$ pip freeze | grep apache-airflow-providers
apache-airflow-providers-celery==2.0.0
apache-airflow-providers-amazon==2.0.0
apache-airflow-providers-google==2.0.0

Deployment

Official Apache Airflow Helm Chart

Deployment details

Deployment Type: GitHub Actions (CI pipeline)
Deployment Details: Running on Ubuntu with Python 3.9 in GitHub Actions CI pipeline.

Anything else?

The problem seems to occur consistently for all workflows triggered by this PR. Skipped checks, particularly those related to static analysis and UI tests, suggest a potential configuration issue or misconfigured dependencies.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@missaarohi missaarohi added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jan 22, 2025
@dosubot dosubot bot added the area:CI Airflow's tests and continious integration label Jan 22, 2025
@potiuk
Copy link
Member

potiuk commented Jan 22, 2025

No. We have https://github.com/apache/airflow/blob/main/dev/breeze/doc/ci/04_selective_checks.md that implement deliberate skipping of some parts of test workflow where the heuristics analysis in selective checks determines that some of the tests can be skipped. This is to make the tests faster and take less resources.

There are sometimes false-negatives - i.e. skipping tests where they should be run, but we are looking at those cases and fixing them as we find them, also we have "canary" builds in main run every 6 hours that run full set of tests in main to see if we accidentally merged something that should have not passed the tests in PR.

If you have concrete example where tests did not run when they should, feel free to report them individually in separate issues - or just explain it in#internal-airflow-ci-cd slack channel on Airlfow Slack.

@potiuk potiuk closed this as completed Jan 22, 2025
@potiuk
Copy link
Member

potiuk commented Jan 22, 2025

Closing as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CI Airflow's tests and continious integration area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

No branches or pull requests

2 participants