ideas, fixes, improvements... and lots of cafeine

[quenenni]

Well well well...
What an excellent plugin...

I needed it badly, so I made it work.
I fixed some stuffs and improve (to my point of view) others.
And I needed it in French.

1. I spent lots of hours to translate all the texts in the templates dir and other files (static/js/client/)

As soon as you change your code to use i12n (locales dir), I can put the french translations myself if you want, but before that, and I 'm sure you already know that, there are some work to do to make it work that way.

2. I also fixed lots of bad paths for images in the template dir and also 2 in statis/css/styles.less.
   In a css file, the path starts from the dir where the css file is placed.

.at2x('../images/close-cyan-12.png');
list-style-image: url(../images/users-cyan-16.png);

3. I changed the width of the pad and put à % instead of a fixed width, because I think it was too small and a bit sad to not use more of the screen and also because a fixed width on small screen would be bad (I didn't test though)
   Other problem, I don't know if it was because it was too small or because it was not a %, but in Chrome (not in Firefox),some buttons (those on the right, from the 'import/export' to the one that shows the connected users) were not there.

#wrapper {
  min-width: 90%;
}

.inside {
  width: 90%;
}

4. You need to find a way to show a date in the locale format of the user.
   I think there are functions that achieve that quite easily.. I think :)

So, those 2 functions should be improved (hooks.js).

line 313: var converter = function (UNIX_timestamp) {
line 325: var converterPad = function (UNIX_timestamp) {

5. I'm sure you already know that too, but some functions exists several times, like to adjust the height of the iframe and that always a bad idea.

6. I'm not sure how really work the retina library (retina.js, a high-resolution image swapper), but I receive lots of:

"NetworkError: 404 Not Found - https://xxxxxx/static/plugins/ep_user_pad_frontend/static/images/[email protected]"

I think it's for all the images.
And I don't know if it's the library that adds the '@2x' at the end of the filename or not, if it's normal or if it means something is wrong with what I did.

8. I removed the 'Etherpad' logo that was top right of your page.
   When testing different sizes of the browser window, it could become messy the way the logo, the username / logout part and the "My groups - Group" nav bar were placed.
   So, in the templates files:

Removed: <img src="./static/plugins/ep_user_pad_frontend/static/images/logo_tug_grey_white-01.png" alt="Etherpad" id="logo">  

Added: <div style="clear: both"></div>
(just before the </header>)

And in static/css/styles.less file:

#sekMenu {
  float: right;
}

9. This is more my idea, but, even if the effect of the footer showing and hiding is quite nice, I don't like to loose some space for the height.
   So I removed the footers in the template files and remove in the css file:

#main {
  padding-bottom: 56px;
}

I'm not against you put your credentials, you deserve it, but it should be placed elsewhere, or smaller at least.

Now, everything is working smoothly... 👍
you really did a great job with that plugin.

If you want to see how it looks like with my version, or if you want my modified files, just contact me.

[quenenni]

For the date format problem (point 4), http://momentjs.com/ seems to do the trick nicely.

[Kisuke]

Wow thanks for the work, man.